Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for the UI code #1498

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Improvements for the UI code #1498

merged 1 commit into from
Feb 28, 2023

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Changes:

  • Code for managing the modal window state was added in parts that did not have it.
  • The code for keeping the node data updated was removed from NodeService and 2 new services were created with similar functionality, but much simpler code, as the old code was virtually unmaintainable and the current structure of the app do no needs it centralized. This will allow to make future changes.
  • Other small code improvements.

How to test this PR:

  • The modal windows for configuring the password for the first time and for configuring the vpn client app should not allow to do anything while an opperation is in progress.
  • Navigating between the visor list and the visor details page should work as before and the app should now respond a bit quicker if navigating rapidly between de details pages of several visors.

@0pcom 0pcom merged commit f0cca86 into skycoin:develop Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants